Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays
Uwe Kleine-König (The Capable Hub) <[email protected]>
| Newsgroups | org.kernel.vger.linux-pwm,dev.linux.lists.asahi,dev.linux.lists.chrome-platform,dev.linux.lists.imx,dev.linux.lists.linux-sunxi,dev.linux.lists.sophgo,org.infradead.lists.linux-amlogic,org.infradead.lists.linux-mediatek,org.infradead.lists.linux-riscv,org.infradead.lists.linux-rockchip,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mips,org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-samsung-soc |
|---|---|
| Message-ID | <akuFirxGTqu_gt4O@monoceros> |
Hello,
On Mon, Jul 06, 2026 at 10:28:16AM +0200, Philippe Mathieu-Daudé wrote:
> Hi Uwe,
>
> On 6/7/26 09:19, Uwe Kleine-König (The Capable Hub) wrote:
> > Hello Chen,
> >
> > On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote:
> > > On 7/5/2026 11:14 PM, Uwe Kleine-König (The Capable Hub) wrote:
> > > > - Use a single space in a of_device_id array terminator; A single space
> > > > after the opening { and before the closing } in non-empty
> > > > initializers;
> > > > - No comma after an array terminator;
> > > > - Also no trailing comma after a named initializer iff the
> > > iff -> if
> >
> > This is actually intended. iff = "if and only if", see e.g.
> > https://en.wikipedia.org/wiki/If_and_only_if .
>
> I agree this scientific idiomatic expression is not well known
> by non-native English speakers, and using the expanded form is
> just simpler to review (thinking at non-native English speaker
> reading your commit in the future).
fine for me, I'll fixup to
- Also no trailing comma after a named initializer if (and only if) the
closing } is on the same line;
when applying.
Best regards
Uwe
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpLheQACgkQj4D7WH0S /k6DEQf+JKDZ+NcR412RMDPBxcWuk831SswOfJipQJVDxTsFWtpZIrZIbOu0ZlBp IEWpfB5nRfHwTSxF6Ceuf2jTc+wkwcRBKeH4MQsZFpGxBjGa4k7YEEfMSDU9S1vU 39G1FIVXnf0sDkUOUGf5zIomYewh4gdCoWRwDnCHsV4QnZKAaKCCEpX0U6QdW2OP diy3iqasYf6KZyXnUyj0HBQRGjBYY4jBvVutXt4KtCqAKW+AcCANOtubadJgydWD xXNkFLpscFQ9aVdyKZK19UP9yKdOwzkjR9pul+TqXDviO0c5UoAZEwMZYDbB1YPi AJloqZ9/3vBcnEjZo3eWYk8zkrQifQ== =vnC0 -----END PGP SIGNATURE-----