Re: Re: [PATCH v10 1/3] dt-bindings: pwm: dwc: Document optional resets property

> 
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Missing matching updates for related bindings in the same IP family.
> --
> 
> commit 05dd50c982c598b86944765d91f297a8c37b303e
> Author: Xuyang Dong <[email protected]>
> 
> dt-bindings: pwm: dwc: Document optional resets property
> 
> This commit updates the DesignWare PWM binding to document two active-low
> reset inputs: presetn and timer_N_resetn. It adds the resets property with
> two items to describe the function of each reset line.
> 
> > diff --git a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml
> > --- a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml
> > +++ b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml
> > @@ -43,6 +43,11 @@ properties:
> >        - const: bus
> >        - const: timer
> >  
> > +  resets:
> > +    items:
> > +      - description: Interface bus (presetn) reset
> > +      - description: PWM timer logic (timer_N_resetn) reset
> > +
> 
> [Severity: Medium]
> The subsystem guidelines note that when a binding has multiple YAML files for
> different device types in the same family, related files may need matching
> updates. Since the DesignWare APB timer IP is described by both this PWM
> binding and the timer binding, does the timer binding also need an update?
> 
> Currently, the timer binding restricts the resets property to a single item:
> 
> Documentation/devicetree/bindings/timer/snps,dw-apb-timer.yaml:properties:resets
>   resets:
>     maxItems: 1
> 
> Defining both hardware resets for the snps,dw-apb-timer compatible will
> cause dt_binding_check to fail due to this inconsistency.
> 

Hi Sashiko,

Thanks for the careful review.

This is not a binding inconsistency issue:
  - We're describing different hardware usage scenarios (PWM vs clocksource)
  - The PWM binding describes what the PWM driver actually needs
  - The timer binding describes what the timer driver actually needs
  - Both reflect their respective hardware requirements accurately

I don't think the number of items in the resets property of the timer binding 
should be updated. Do you think this is acceptable?

Best regards,
Xuyang Dong

> >    snps,pwm-number:
> >      $ref: /schemas/types.yaml#/definitions/uint32
> >      description: The number of PWM channels configured for this instance
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1