Re: [PATCH v3] rust: pwm: replace `core::mem::zeroed` with `pin_init::zeroed`

Konstantin Ryabitsev <[email protected]>
Newsgroups org.kernel.vger.linux-pwm,org.kernel.linux.tools,org.kernel.vger.linux-kernel,org.kernel.vger.rust-for-linux
Message-ID <20260811-garrulous-serpent-of-agreement-cf9b19@meerkat>
On Tue, Aug 11, 2026 at 07:04:49AM +0200, Uwe Kleine-König wrote:
> Applied to
> 
> 	https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
> 
> for the 7.3 merge window.
> 
> b4 behaved strange on that patch:
> 
> 	$ b4 am -s -l -t -3 [email protected]
> 	Grabbing thread from lore.kernel.org/all/[email protected]/t.mbox.gz
> 	Analyzing 2 messages in the thread
> 	Looking for additional code-review trailers on lore.kernel.org
> 	Analyzing 23 code-review messages
> 	Checking attestation on all messages, may take a moment...
> 	---
> 	  ✓ [PATCH v3] rust: pwm: replace `core::mem::zeroed` with `pin_init::zeroed`
> 	    + Link: https://patch.msgid.link/[email protected]
> 	    + Signed-off-by: Uwe Kleine-König <[email protected]>
> 	  ---
> 	  ✓ Signed: DKIM/privacyrequired.com
> 	---
> 	Total patches: 1
> 	---
> 	NOTE: some trailers ignored due to from/email mismatches:
> 	    ! Trailer: Suggested-by: Benno Lossin <[email protected]>
> 	     Msg From: Miguel Ojeda <[email protected]>
> 	    ! Trailer: Acked-by: Michal Wilczynski <[email protected]>
> 	     Msg From: Miguel Ojeda <[email protected]>
> 	    ! Trailer: Signed-off-by: Francis Laniel <[email protected]>
> 	     Msg From: Miguel Ojeda <[email protected]>
> 	    ! Trailer: Reviewed-by: Alexandre Courbot <[email protected]>
> 	     Msg From: Miguel Ojeda <[email protected]>
> 	NOTE: Rerun with -S to apply them anyway
> 	Preparing fake-am for v3: rust: pwm: replace `core::mem::zeroed` with `pin_init::zeroed`
> 	  range: 2707b9df955d..81c3f2b030a1
> 	Preared a fake commit range for 3-way merge (2707b9df955d..81c3f2b030a1)
> 	---
> 	 Link: https://patch.msgid.link/[email protected]
> 	 Base: applies clean to current tree
> 	       git checkout -b v3_20260603_laniel_francis_privacyrequired_com HEAD
> 	       git am -3 ./v3_20260603_laniel_francis_rust_pwm_replace_core_mem_zeroed_with_pin_init_zeroed.mbx
> 
> I didn't research what went wrong there and the trailer made it into the
> patch anyhow and adding -S doesn't change the patch. I added the
> [email protected] mailing list to Cc:, maybe someone there wants to debug that.

It was just Miguel responding with a suggestion how to better reorder
trailers. Since we can't tell this case from the case when someone actually
replies with a follow-up trailer, hence the error.

I added a special case where we ignore trailers we find in the follow-up if
these trailers already exist in the patch anyway, so, at least for this
particular case, the problem shouldn't resurface.

-K
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.