Re: [PATCH v3 1/2] dt-bindings: pwm: add Axiado AX3000 PWM

On 8/12/2026 1:16 PM, Krzysztof Kozlowski wrote:
> On Tue, Aug 11, 2026 at 02:01:50AM -0700, Petar Stepanovic wrote:
>> The Axiado AX3000 and AX3005 SoCs include PWM controllers that can be
>> used to generate configurable PWM output signals.
>>
>> Signed-off-by: Petar Stepanovic <[email protected]>
>> ---
>>  .../devicetree/bindings/pwm/axiado,ax3000-pwm.yaml | 53 ++++++++++++++++++++++
>>  MAINTAINERS                                        |  8 ++++
>>  2 files changed, 61 insertions(+)
>>
> Where did you explain reason to drop the tag?
>
> <form letter>
> This is a friendly reminder during the review process.
>
> It looks like you received a tag and forgot to add it.
>
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions of patchset, under or above your Signed-off-by tag, unless
> patch changed significantly (e.g. new properties added to the DT
> bindings). Tag is "received", when provided in a message replied to you
> on the mailing list. Tools like b4 can help here. However, there's no
> need to repost patches *only* to add the tags. The upstream maintainer
> will do that for tags received on the version they apply.
>
> Please read:
> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
>
> If a tag was not added on purpose, please state in the patch changelog
> or cover letter why and what changed.
> </form letter>

The tag was dropped because I changed the compatible schema after your
review to express AX3005 compatibility using the AX3000 fallback. I
described the binding change in the changelog, but I did not explicitly
state that this was the reason for dropping your Reviewed-by tag. I will
make that clear in the next version.

After checking your DTS101 presentation again, I found that my case is
better represented by the fallback-compatible example, where the more
specific compatible is followed by the fallback compatible.

The second AX3000 entry is a typo; it should be AX3005 followed by
AX3000 as the fallback. I will fix it and validate the DTS against the
updated binding.

So the resulting binding will be:

compatible:
oneOf:
   - const: axiado,ax3000-pwm
   - items:
       - const: axiado,ax3005-pwm
       - const: axiado,ax3000-pwm

>
>> diff --git a/Documentation/devicetree/bindings/pwm/axiado,ax3000-pwm.yaml b/Documentation/devicetree/bindings/pwm/axiado,ax3000-pwm.yaml
>> new file mode 100644
>> index 000000000000..7297abccbc24
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pwm/axiado,ax3000-pwm.yaml
>> @@ -0,0 +1,53 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pwm/axiado,ax3000-pwm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Axiado AX3000 PWM controller
>> +
>> +maintainers:
>> +  - Petar Stepanovic <[email protected]>
>> +  - Akhila Kavi <[email protected]>
>> +  - Prasad Bolisetty <[email protected]>
>> +
>> +description:
>> +  The Axiado PWM controller found on the AX3000 and AX3005 SoCs.
>> +
>> +allOf:
>> +  - $ref: pwm.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - const: axiado,ax3000-pwm
>> +      - items:
>> +          - const: axiado,ax3000-pwm
> So 3000 is listed twice. You need to test your DTS.

Best regards,
Petar