Re: [PATCH v3 2/2] pwm: meson: Add support for Amlogic S7

Uwe Kleine-König <[email protected]> Tue, 18 Aug 2026 23:33:04 +0200

Newsgroups	org.kernel.vger.linux-pwm,org.infradead.lists.linux-amlogic,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID	<aoTOjGhqfdfk6Ze-@monoceros>

Hello Alexandre,

thanks for your review, that's very appreciated.

On Tue, Aug 18, 2026 at 02:53:50PM +0200, Alexandre Mergnat wrote:
> > @@ -642,7 +672,11 @@ static const struct of_device_id meson_pwm_matches[] = {
> >  		.compatible = "amlogic,meson-s4-pwm",
> >  		.data = &pwm_s4_data
> >  	},
> > -	{},
> > +	{
> > +		.compatible = "amlogic,s7-pwm",
> > +		.data = &pwm_s7_data
> > +	},
> > +	{ }
> 
> Small nit: changing the sentinel from "{}," to "{ }" is unrelated to
> adding S7 support. Patches tend to be easier to review when they carry only
> the functional change, so would you mind dropping it, or splitting it into
> its own trivial cleanup?

Just skimming your mail, only here I want to express a little
disagreement. While I'm generally a friend of "each patch does exactly
one atomic thing", IMHO such reformatting in an array that is touched
anyhow is fine, and a separate commit that just updates the terminator
in this one array is over-engineered.

Just mention it in the commit log and that's fine for me.

Best regards
Uwe

signature.asc (application/pgp-signature, 488 B)