Re: [PATCH v2 1/3] md/raid10: fix still_degraded being inverted in raid10_sync_request()

Mykola Marzhan <[email protected]> Sun, 26 Jul 2026 14:25:10 +0200
Newsgroups org.kernel.vger.linux-raid,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
> -					still_degraded = false;
> +					still_degraded = true;

I posted the same one-liner on 19 July -- flagging it only so it is not
applied twice:

  https://lore.kernel.org/linux-raid/[email protected]/

No objection to yours going in, and I will drop mine if it does:

Reviewed-by: Mykola Marzhan <[email protected]>

Identical hunk and the same Fixes: tag.  Mine picked up Reviewed-by from
Yu Kuai and Paul Menzel on that posting.
Your changelog is the better of the two: it carries a measured
reproducer where mine only reasons through the failure.

Your patch 3 and patch 2 of my 19 July series hit the same unit mismatch
-- raid10's recovery cursor is in per-device space while its bitmap is
indexed by array sectors -- but at different sites, and they do not
overlap:

  https://lore.kernel.org/linux-raid/[email protected]/

Yours converts the bitmap-reported span into per-device sectors inside
raid10_sync_request(); mine stops md_do_sync() handing
bitmap_ops->skip_sync_blocks() an offset raid10 cannot interpret.  Both
are still needed.  Yu Kuai has asked me to re-check mine against his
llbitmap reshape series, so mine is still under discussion.

Mykola