Re: [PATCH v6 11/12] nvme-rdma: ratelimit the map-failure error message

Logan Gunthorpe <[email protected]> Mon, 27 Jul 2026 09:48:06 -0600

Newsgroups	org.kernel.vger.linux-raid,org.infradead.lists.linux-nvme,org.kernel.vger.linux-block,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci,org.kernel.vger.linux-rdma,org.kernel.vger.stable
Message-ID	<[email protected]>


On 2026-07-26 05:32, Mykola Marzhan wrote:
> A mapping failure is per-request and, for an unroutable P2P transfer,
> deterministic: a workload that keeps issuing one turns this into a
> log line per I/O.  Ratelimit it, as nvme's per-I/O error logging
> (nvme_log_error()) already is.
> 
> Assisted-by: Claude:claude-fable-5
> Signed-off-by: Mykola Marzhan <[email protected]>

Thanks!

Reviewed-by: Logan Gunthorpe <[email protected]>

> ---
>  drivers/nvme/host/rdma.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index c38d949502b7..2f50509a7a61 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -2040,8 +2040,8 @@ static blk_status_t nvme_rdma_queue_rq(struct blk_mq_hw_ctx *hctx,
>  
>  	err = nvme_rdma_map_data(queue, rq, c);
>  	if (unlikely(err < 0)) {
> -		dev_err(queue->ctrl->ctrl.device,
> -			     "Failed to map data (%d)\n", err);
> +		dev_err_ratelimited(queue->ctrl->ctrl.device,
> +				    "Failed to map data (%d)\n", err);
>  		goto err;
>  	}
>