Re: [PATCH net-next v4 3/3] net/smc: transition to RDMA core CQ pooling

On 2026/7/16 19:37, D. Wythe wrote:
>   static void smc_copy_netdev_ifindex(struct smc_ib_device *smcibdev, int port)
> @@ -952,7 +916,6 @@ static int smc_ib_add_dev(struct ib_device *ibdev)
>   	INIT_WORK(&smcibdev->port_event_work, smc_ib_port_event_work);
>   	atomic_set(&smcibdev->lnk_cnt, 0);
>   	init_waitqueue_head(&smcibdev->lnks_deleted);
> -	mutex_init(&smcibdev->mutex);

Since smc_ib_setup_per_ibdev() and smc_ib_cleanup_per_ibdev() were removed,
the .mutex field is now unused and can be dropped.

Thanks.

>   	mutex_lock(&smc_ib_devices.mutex);
>   	list_add_tail(&smcibdev->list, &smc_ib_devices.list);
>   	mutex_unlock(&smc_ib_devices.mutex);
> @@ -1001,7 +964,6 @@ static void smc_ib_remove_dev(struct ib_device *ibdev, void *client_data)
>   	pr_warn_ratelimited("smc: removing ib device %s\n",
>   			    smcibdev->ibdev->name);
>   	smc_smcr_terminate_all(smcibdev);
> -	smc_ib_cleanup_per_ibdev(smcibdev);
>   	ib_unregister_event_handler(&smcibdev->event_handler);
>   	cancel_work_sync(&smcibdev->port_event_work);
>   	kfree(smcibdev);