Re: [PATCH net] net/smc: validate peer CDC cursor against RMBE size before accepting it

Ibrahim Hashimov <[email protected]>
Newsgroups org.kernel.vger.linux-rdma,org.kernel.vger.linux-kernel,org.kernel.vger.linux-s390,org.kernel.vger.netdev
Message-ID <[email protected]>
> The insight is yours either way -- may I add your Suggested-by (or
> Co-developed-by)?

Please do, and thanks for running it end to end. Suggested-by is the
honest one -- I pointed at the gap and the advance-bound, you did the
series. If you carry the

	if (smc_curs_diff(size, &old, &temp) > size)
		return;

verbatim, Co-developed-by is fine too, your call. Either way:

	Ibrahim Hashimov <[email protected]>

And your split is right -- advance-bound as the early catch, bytes_to_rcv
after the atomic_add for the accumulation the per-cursor check can't see.

Thanks,
Ibrahim
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.