Re: [PATCH v5 07/10] md/raid1,raid10: skip futile retries on P2PDMA mapping failures
Logan Gunthorpe <[email protected]>
| Newsgroups | org.kernel.vger.linux-rdma,org.infradead.lists.linux-nvme,org.kernel.vger.linux-block,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci,org.kernel.vger.linux-raid,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On 2026-07-23 2:42 p.m., Mykola Marzhan wrote:
> BLK_STS_P2PDMA reflects the peer/member pairing, not member health:
> retrying the same pages on the same member cannot succeed. Keep
> WriteErrorSeen so the range stays fenced, but skip WantReplacement and
> FailFast eviction, as commit f7b24c7b41f2 ("md/raid1,raid10: don't fail
> devices for invalid IO errors") did for BLK_STS_INVAL.
>
> The failure is whole-range and deterministic, so narrow_write_error()'s
> block-by-block submit_bio_wait() retries are pointless. Record the
> whole range as a bad block in the completion handler instead.
>
> Fixes: 02666132403a ("md: propagate BLK_FEAT_PCI_P2PDMA from member devices to RAID device")
> Assisted-by: Claude:claude-fable-5
> Signed-off-by: Logan Gunthorpe <[email protected]>
> Signed-off-by: Mykola Marzhan <[email protected]>
Change my no longer correct first Signed-off-by to:
Reviewed-by: Logan Gunthorpe <[email protected]>
Logan