Re: [PATCH 00/36] treewide: remove conditional returns with no effect
Jakub Kicinski <[email protected]>
| Newsgroups | org.kernel.vger.linux-rdma,dev.linux.lists.dm-devel,dev.linux.lists.iommu,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.freedesktop.lists.nouveau,org.kernel.vger.dmaengine,org.kernel.vger.linux-cifs,org.kernel.vger.linux-clk,org.kernel.vger.linux-crypto,org.kernel.vger.linux-edac,org.kernel.vger.linux-gpio,org.kernel.vger.linux-iio,org.kernel.vger.linux-input,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media,org.kernel.vger.linux-pm,org.kernel.vger.linux-rtc,org.kernel.vger.linux-s390,org.kernel.vger.linux-scsi,org.kernel.vger.linux-sound,org.kernel.vger.linux-usb,org.kernel.vger.linux-wireless,org.kernel.vger.lvs-devel,org.kernel.vger.netdev,org.kernel.vger.netfilter-devel,org.kernel.vger.platform-driver-x86,org.kvack.linux-mm,org.osuosl.intel-wired-lan |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 24 Jul 2026 03:45:02 +0900 Sang-Heon Jeon wrote: > Patch 1 adds a Coccinelle script that matches the pattern, including > negation and constant-comparison variants. Where a local variable is > assigned right before the check, the assignment and the two returns > turn into a single return of the assigned expression. Huh, I thought we already had such script. Various script children have been sending such "cleanups" in the past. > Patches 2-36 are generated by the script, with hand fixes to restore > unexpectedly removed comments and to fix the formatting checkpatch.pl > complained about. Please post patches 4,7,8,9 as a separate series. Since you only CCed netdev on subset of the series patchwork thinks there are patches missing and doesn't kick off any CI.