Re: [PATCH net 2/2] DO-NOT-MERGE: selftest: add rxe mr_check_range() overflow reproducer

在 2026/8/2 18:49, [email protected] 写道:
> August 3, 2026 at 6:28 AM, "Zhu Yanjun" <[email protected] mailto:[email protected]?to=%22Zhu%20Yanjun%22%20%3Cyanjun.zhu%40linux.dev%3E > wrote:
>
>
>>>   Thanks a lot. When I run rdma selftests. I got the following:
>>>   "
>>>   # Warning: file rxe_mr_overflow.sh is not executable
>>>   "
>>>   You need to make rxe_mr_overflow.sh executable.
>>>
>> After this testcase is run, please remove this bin file rxe_mr_overflow in tools/testing/selftests/rdma.
>>
>> Thanks a lot.
> Hi Yanjun,
>
> Thank you for your reply.
>
> Regarding the selftest patch, my initial thought was that the selftest does not need to cover this particular
> issue separately, which is why I added the DO-NOT-MERGE tag.
>
> However, after reading your feedback, I would like to clarify your suggestion: do you mean that I should
> integrate the attached rxe_mr_overflow.c into the selftest suite? Or is there a different way you would
> recommend?  If you fell OK, I would prefer to drop this selftest patch entirely.
>
> Please let me know your preferred approach. I'm happy to adjust it. Thanks again for your guidance!
>
> Best regards,


Thank you for the clarification.

I agree that we can drop the selftest patch. My original suggestion was 
mainly to make sure we have proper coverage for this issue, but after 
considering your explanation, I think adding a standalone selftest for 
this particular case may not be necessary.

The bug fix itself is the important part, and keeping the selftest out 
will also avoid adding a test case that may not provide much long-term 
value.

Please feel free to remove the selftest patch and keep the fix patch only.

Thanks again for your work and for discussing this with me.

Best regards,
Zhu Yanjun


> Gang
>
>> Zhu Yanjun
>>
-- 
Best Regards,
Yanjun.Zhu