Re: [PATCH net 2/2] DO-NOT-MERGE: selftest: add rxe mr_check_range() overflow reproducer
Zhu Yanjun <[email protected]>
| Newsgroups | org.kernel.vger.linux-rdma |
|---|---|
| Message-ID | <[email protected]> |
在 2026/8/5 0:47, [email protected] 写道: >> Thank you for the clarification. >> >> I agree that we can drop the selftest patch. My original suggestion was mainly to make sure we have proper coverage for this issue, but after considering your explanation, I think adding a standalone selftest for this particular case may not be necessary. >> >> The bug fix itself is the important part, and keeping the selftest out will also avoid adding a test case that may not provide much long-term value. > Hi Yanjun, > > Thank you for your feedback. > > No offense at all. > > Regarding Patch 1 (the actual fix), I noticed that it hasn't received a Reviewed-by > or any further comments yet. As a newcomer to the RDMA community, I just want to > make sure I'm following the right process. Should I proactively send a v2 with only > the fix (now that the selftest is removed), or is it preferable to wait for more > reviews on the current version before resending? > > Please don't take this as a nudge — I'm genuinely asking because I want to avoid > missing any step that I should be taking on my side. I'm happy to wait if > that's the usual practice. Hi Gang, I think it's fine to send a v2 with only the fix. There's no need to include the selftest in this series anymore. If you'd like, you can also add the following since I have reviewed this commit and made tests in my local host. It can pass my local testcases. Reviewed-by: Zhu Yanjun <[email protected]> Thanks, Zhu Yanjun > > Thanks > Gang -- Best Regards, Yanjun.Zhu