Re: [PATCH net-next v1 2/2] net/smc: reduce TX slot contention with exclusive wait

Mahanta Jambigi <[email protected]>
Newsgroups org.kernel.vger.linux-rdma,org.kernel.vger.linux-s390,org.kernel.vger.netdev
Message-ID <[email protected]>

On 06/08/26 12:12 pm, D. Wythe wrote:
> smc_wr_tx_get_free_slot() waits for a free TX slot with
> wait_event_interruptible_timeout(). Since the wait_event family
> enqueues waiters as non-exclusive, wake_up() may wake multiple
> waiters even though only one can use the slot, causing
> thundering-herd contention when slots are scarce.

Have you run any performance benchmarks (e.g. redis-benchmark or uperf)
to quantify the benefit of this change?

Since the motivation is to reduce contention caused by multiple waiters
being awakened for a single available TX slot, it would be helpful to
see measurable results. Please share the baseline and patched throughput
figures, and any observed throughput differences.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.