Re: [PATCH net v2] dibs: fix double free of dmb_clientid_arr
Jakub Kicinski <[email protected]>
| Newsgroups | org.kernel.vger.linux-rdma,org.kernel.vger.linux-kernel,org.kernel.vger.linux-s390,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 6 Aug 2026 14:04:47 +0200 Hidayath Khan wrote: > dibs_dev_add() frees dibs->dmb_clientid_arr on both of its failure > paths, but does not clear the pointer. dibs_lo_dev_probe() then frees > the same pointer again in its err_reg path, so a failing device_add() > or sysfs_create_group() results in a double free. > > Drop the kfree() from dibs_lo_dev_probe(). This should be squashed with Alexandra's fix.