Re: [PATCH net-next V2 13/13] selftests: drv-net: psp: Add a test for PSP with HW-GRO

On Fri, 2026-08-07 at 18:00 -0700, Jakub Kicinski wrote:
> On Tue, 4 Aug 2026 11:35:35 +0300 Tariq Toukan wrote:
> >  tools/testing/selftests/drivers/net/psp.py    | 131
> > ++++++++++++++++--
> 
> This is not the right place, and the test coverage is really weak.
> Please see the level of detail we have in the other gro test cases.
> This should probably be a separate test due to a crypto complexity,
> and we should exercise the various header fields PSP has, as well
> as crypto failures?

I'll move the hw gro tests into a dedicated psp_gro.py test for the
next version and increase the assertion strength similar to other HW
GRO tests.

I found a way to spawn multiple psp_responders to verify cross-stream
assembly errors and other weird edge cases.

In order to avoid duplicating a lot of psp connection management code,
I hope it's fine to move shared stuff in a psp_lib.py file (similar to
hw/devmem_lib.py). I know you're against frameworkifying stuff, but in
this case I think it's a good choice.

All of this will push the series to 15 patches.

Cosmin.