Re: [PATCH for-next v2 0/3] RDMA/efa: Add support for 128B admin v2 SQ entry
Jason Gunthorpe <[email protected]>
| Newsgroups | org.kernel.vger.linux-rdma |
|---|---|
| Message-ID | <[email protected]> |
On Sun, Aug 09, 2026 at 07:22:37PM +0000, Yonatan Nachum wrote:
>
> Hi, kind reminder for this series.
> I reviewed the Sashiko comments and they aren't correct.
They look correct to me, the stack buffers should be u64 arrays for
the alignment reason it gave.
common_v2 = (struct efa_admin_aq_common_desc_v2 *)aq_entry;
common = &common_v2->common;
common->command_id = cmd_id;
^^^^^^^^^^^^^^^^^^^
Stores u16 to an u8 aligned memory area.
You should also fix the race it pointed it.
Jason