Re: [PATCH net-next] net/rds: clear i_rx_lat_trace in rds_inc_path_init()
| Newsgroups | org.kernel.vger.linux-rdma,org.kernel.vger.netdev |
|---|---|
| Message-ID | <178661881213.2374993.12011037077966249761.git-patchwork-notify@kernel.org> |
Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>: On Sun, 9 Aug 2026 22:56:31 -0700 you wrote: > The commit that introduced the receive-path latency trace added the > clearing of inc->i_rx_lat_trace[] to rds_inc_init() only; > rds_inc_path_init() never got it. > > That asymmetry matters for the one caller that reuses memory: > rds_tcp_data_recv() carves its rds_tcp_incoming out of a kmem_cache > with no zeroing and no constructor, so after rds_inc_path_init() the > array still holds the timestamps of whatever message previously > occupied that slab object. No stale value is user-visible today - > every message that reaches the socket happens to overwrite all four > slots (RX_HDR at allocation, RX_START when the header completes, > RX_END at delivery, RX_CMSG at recvmsg time) before > RDS_CMSG_RXPATH_LATENCY reads them back as deltas - but that is a > property of the current writers, not of the init contract, and a > future trace point or an early-exit path would expose another > message's timestamps to userspace. > > [...] Here is the summary with links: - [net-next] net/rds: clear i_rx_lat_trace in rds_inc_path_init() https://git.kernel.org/netdev/net-next/c/68b3d4dbaf20 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html