[PATCH, net-next] net/mlx5: Use kfree() to match kzalloc_obj() in mlx5_events_cleanup()
lirongqing <[email protected]>
| Newsgroups | org.kernel.vger.linux-rdma,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
From: Li RongQing <[email protected]> dev->priv.events is allocated in mlx5_events_init() with kzalloc_obj(), which is a kmalloc-family allocator, so it must be released with kfree(). kvfree() happens to work here because it falls back to kfree() for non-vmalloc addresses, but it is semantically imprecise. Use kfree() to correctly pair with the allocation and to match the error path in mlx5_events_init(), which already uses kfree(events). Signed-off-by: Li RongQing <[email protected]> --- drivers/net/ethernet/mellanox/mlx5/core/events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/events.c b/drivers/net/ethernet/mellanox/mlx5/core/events.c index 4d7f35b..fc5ecce 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/events.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/events.c @@ -396,7 +396,7 @@ int mlx5_events_init(struct mlx5_core_dev *dev) void mlx5_events_cleanup(struct mlx5_core_dev *dev) { destroy_workqueue(dev->priv.events->wq); - kvfree(dev->priv.events); + kfree(dev->priv.events); } void mlx5_events_start(struct mlx5_core_dev *dev) -- 2.9.4