Re: [PATCH 31/42] ASoC: cix-ipbloq: Use devm_of_reserved_mem_device_init()

Gary Yang <[email protected]>
Newsgroups org.kernel.vger.linux-remoteproc,dev.linux.lists.imx,dev.linux.lists.linux-staging,dev.linux.lists.linux-sunxi,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-mediatek,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media,org.kernel.vger.linux-mips,org.kernel.vger.linux-mmc,org.kernel.vger.linux-sound,org.kernel.vger.linux-tegra,org.ozlabs.lists.linux-aspeed,org.ozlabs.lists.linuxppc-dev,org.ozlabs.lists.openbmc
Message-ID <akxXtlUYtT3T-huE@gary-System-Product-Name>
On 2026-07-04 01:08, Mukesh Ojha wrote:

> [Some people who received this message don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL
> 
> Use the devres-managed devm_of_reserved_mem_device_init() to ensure
> the reserved memory region is released on device removal, fixing a
> missing cleanup in the original code.
> 
> Signed-off-by: Mukesh Ojha <[email protected]>
> ---
>  sound/hda/controllers/cix-ipbloq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/hda/controllers/cix-ipbloq.c b/sound/hda/controllers/cix-ipbloq.c
> index c1084a915c13..815932e5c58b 100644
> --- a/sound/hda/controllers/cix-ipbloq.c
> +++ b/sound/hda/controllers/cix-ipbloq.c
> @@ -257,7 +257,7 @@ static int cix_ipbloq_hda_probe(struct platform_device *pdev)
> 
>         dma_set_mask_and_coherent(hda->dev, DMA_BIT_MASK(32));
> 
> -       err = of_reserved_mem_device_init(hda->dev);
> +       err = devm_of_reserved_mem_device_init(hda->dev);
>         if (err < 0 && err != -ENODEV) {
>                 dev_err(hda->dev,
>                         "failed to init reserved mem for DMA, err = %d\n", err);

Reviewed-by: Gary Yang <[email protected]>

> --
> 2.53.0
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.