Re: [PATCH v4 01/10] dt-bindings: firmware: qcom: tmd: add TMD device type constants
Gaurav Kohli <[email protected]>
| Newsgroups | org.kernel.vger.linux-remoteproc,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-hardening,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm |
|---|---|
| Message-ID | <[email protected]> |
On 7/7/2026 12:51 AM, Krzysztof Kozlowski wrote: > On 06/07/2026 20:11, Daniel Lezcano wrote: >>>> >>>> I agree there are more TMDs but if they are unused for the moment, why do we >>>> need to add them ? Can we do that incrementally ? >>> >>> That's what I am trying to understand: why the implementation uses only >>> the selected two devices, if the modem on Kodiak supports others. How >>> can we find out, which TMDs to use on other devices. >> >> My understanding is that is an initial thermal setup. Gaurav will add >> them step by step while setting up all the thermal zones instead of >> sending a big patchset. And TBH, that will be much easier to review. > > Not sure if I understand correctly, but bindings must be posted complete > now, not later. Only TMD endpoints connected with a thermal zone in the DT are described, these cover all required kernel-managed TMDs. Others, such as battery current limiting (BCL) and cold temperature protection, are not controlled from the kernel thermal framework. Will update the cover letter with these details. > > Best regards, > Krzysztof