Re: (subset) [PATCH 1/4] remoteproc: qcom: Fix glink->node reference leak in qcom_add_glink_subdev
Bjorn Andersson <[email protected]> Fri, 10 Jul 2026 13:07:06 -0500
| Newsgroups | org.kernel.vger.linux-remoteproc,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 18 Jun 2026 18:50:54 +0530, Uday Khare wrote:
> In qcom_add_glink_subdev(), the device node reference acquired via
> of_get_child_by_name() is stored in glink->node. If the subsequent
> kstrdup_const() allocation for glink->ssr_name fails, the function
> returns early without calling of_node_put() on glink->node, leaking
> the reference count.
>
> Fix this by adding of_node_put(glink->node) on the error path before
> returning.
>
> [...]
Applied, thanks!
[1/4] remoteproc: qcom: Fix glink->node reference leak in qcom_add_glink_subdev
commit: ed5dd2a9b716568ff7d6446322ee60846af313aa
Best regards,
--
Bjorn Andersson <[email protected]>