Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,milos-pas: Add Eliza CDSP compatible

Abel Vesa <[email protected]> Tue, 21 Jul 2026 12:42:57 +0300
Newsgroups org.kernel.vger.linux-remoteproc,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID <6tmbpelyk2ngvrfmcpb5owli7oo54u63i4w46jxbbj5g3fppv4@4amnegv2u3bs>
On 26-07-21 11:22:52, Krzysztof Kozlowski wrote:
> On Tue, Jul 14, 2026 at 03:24:01PM +0300, Abel Vesa wrote:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          enum:
> > +            - qcom,eliza-cdsp-pas
> > +    then:
> > +      properties:
> > +        power-domains:
> > +          items:
> > +            - description: CX power domain
> > +            - description: MX power domain
> > +            - description: NSP power domain
> > +        power-domain-names:
> > +          items:
> > +            - const: cx
> > +            - const: mx
> > +            - const: nsp
> 
> No, do not grow the ifs. Eliza belongs to class of SM8750, so I don't
> get why it was and it is being added here.

I'm assuming you meant SM8550 here, right?

Why does Eliza belong to SM8750 but Milos doesn't?

Was Milos also a mistake?