Re: [PATCH v2 1/4] dt-bindings: remoteproc: imx_rproc: document optional "memory-region-names"
Krzysztof Kozlowski <[email protected]> Fri, 31 Jul 2026 11:42:33 +0200
| Newsgroups | org.kernel.vger.linux-remoteproc,dev.linux.lists.imx,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 11/06/2026 16:24, Frank Li wrote:
> On Thu, Jun 11, 2026 at 03:47:00PM +0200, Krzysztof Kozlowski wrote:
>> On 10/06/2026 16:29, Frank Li wrote:
>>> For example:
>>>
>>> rsc_table: rsc-table@90000000
>>> { ret = <0x90000000>;
>>> no-map;
>>> }
>>>
>>> m4 {
>>> ...
>>> memory-region = <&rsc_table>;
>>> }
>>>
>>> If you change node name "rsc-table" to "memory", driver will failure
>>> because it parse node name "rsc-table", which phandle point to. but no
>>> binding to restrict node name to "rsc-table". So rsc-table became hidden
>>> ABI.
>>
>> Then you need to fix the driver to not parse the node names. Node names
>> are not supposed to be ABI.
>
> Yes, that is this patch set's purpose. Just need below steps to do smooth
> migration.
> 1. allow memory-region-name as options for binding
> 2. update driver to parse memory-region-names
> 3. update all dts to add memory-region-names
> 4. remove old Node name code and change binding to force memory-region-names
>
Obviously that is ABI break, so no.
Fix the driver properly instead of coming with band-aid solutions
ignoring my feedback here.
v3 repeats THE SAME mistakes and basically asks me to give the same NAK.
Best regards,
Krzysztof