Re: [PATCH 2/2] gpio: rcar: Add R-Car X5H (R8A78000) support

Geert Uytterhoeven <[email protected]> Tue, 7 Jul 2026 15:53:39 +0200

Newsgroups	org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel
Message-ID	<CAMuHMdWnTatYWWxXS9p=_fQVSEH0fH4KzYMKKiNCN+ocSTmoww@mail.gmail.com>

Hi Bartosz,

On Tue, 7 Jul 2026 at 15:48, Bartosz Golaszewski <[email protected]> wrote:
> On Mon, 6 Jul 2026 15:06:01 +0200, Marek Vasut <[email protected]> said:
> > On 7/6/26 11:19 AM, Bartosz Golaszewski wrote:
> >>> +static inline int gpio_rcar_remap_offset(struct gpio_rcar_priv *p, int *offs)
> >>> +{
> >
> > I am hoping to get some input on this remap function.
>
> You mean its potential impact on performance or the implementation? In any
> case, as Geert said: a table of function pointers could help to improve it.
> I don't mind it in its current form if it works for you.

A table of register offsets.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds