Re: [PATCH v3 1/5] PCI: dwc: Determine whether iMSI is used before calling .init
Manivannan Sadhasivam <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <p4it4hcg24narbtjtoqdk6zg7wpfs5hc2mm77acyoi6hwfkh5u@5bqlwhylosmo> |
On Mon, Jul 06, 2026 at 07:48:24PM +0200, Marek Vasut wrote: > On 7/6/26 6:43 PM, Manivannan Sadhasivam wrote: > > On Wed, Jul 01, 2026 at 10:37:44PM +0200, Marek Vasut wrote: > > > The R-Car Gen4 PCIe controller integration configures MSI registers > > > in the controller driver .init callback, because those registers > > > have to be configured while PERST signal is asserted, and the PERST > > > signal is asserted across the controller driver .init callback. > > > > > > The registers have to be configured differently in case the iMSI is > > > or is not used. Assign pp->use_imsi_rx before the controller driver > > > .init callback is called, so the controller driver .init callback > > > implementation can use the pp->use_imsi_rx value. > > > > > > Signed-off-by: Marek Vasut <[email protected]> > > > > LGTM! > Thank you. Can I get AB/RB before sending V4 ? Why? Since this series goes through PCI tree and all PCI patches are controller patches, I'm going to merge the series. So no need of the A-b/R-b tags. - Mani -- மணிவண்ணன் சதாசிவம்