RE: [PATCH v3 5/9] regulator: renesas-usb-vbus-regulator: Add RZ/G3L VBUS regulator support

Hi Geert, Mark,

Thanks for the feedback.

> -----Original Message-----
> From: Mark Brown <[email protected]>
> Sent: 08 July 2026 11:39
> Subject: Re: [PATCH v3 5/9] regulator: renesas-usb-vbus-regulator: Add RZ/G3L VBUS regulator support
> 
> On Wed, Jul 08, 2026 at 10:28:46AM +0200, Geert Uytterhoeven wrote:
> > On Wed, 8 Jul 2026 at 10:10, Biju Das <[email protected]> wrote:
> 
> > > I will switch to single init explicitly registering 2 drivers like
> > > [1]
> 
> > Why do you need two platform_driver instances?
> > Because of the different device names? You can use
> > platform_driver.id_table for named platform devices, just like you use
> > platform_driver.driver.of_match_table for DT.
> 
> Yes, that seems more natural for this - the ID table can point to the set of regulators to register.

OK, will switch to platform_driver.id_table.

Note, Initially I had an issue in probing the device related to
id_table match due to string length restriction in [1], so adjusted
the length to less than 24 chars.

[1]https://elixir.bootlin.com/linux/v7.1.2/source/include/linux/mod_devicetable.h#L604

Cheers,
Biju