Re: [PATCH v2 3/6] clk: renesas: Add R-Car X5H CPG driver
Marek Vasut <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-clk,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm |
|---|---|
| Message-ID | <[email protected]> |
On 7/8/26 12:15 PM, Geert Uytterhoeven wrote:
[...]
> +static int register_fixed_clks(struct r8a78000_cpg_priv *priv)
> +{
> + struct device *dev = priv->dev;
> + unsigned long rate;
> + struct clk_hw *hw;
> + const char *name;
> +
> + for (unsigned int i = 0; i < ARRAY_SIZE(fixed_clk_rates); i++) {
> + rate = fixed_clk_rates[i];
> + name = devm_kasprintf(dev, GFP_KERNEL, "cpg-%lu", rate);
> + if (!name)
> + return -ENOMEM;
> +
> + hw = clk_hw_register_fixed_rate(dev, name, NULL, 0, rate);
Would it be viable to use devm_clk_hw_register_fixed_rate() here ?
> + if (IS_ERR(hw)) {
> + while (i-- > 0)
> + clk_hw_unregister_fixed_rate(priv->fixed_hws[i]);
> + return PTR_ERR(hw);
> + }
> +
> + priv->fixed_hws[i] = hw;
> + }
> +
> + return devm_add_action_or_reset(dev, unregister_fixed_clks, priv);
> +}
[...]