[PATCH] PCI: rcar-gen4: Inline GIC_TRANSLATER offset macro
Marek Vasut <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
Instead of pulling in the whole linux/irqchip/arm-gic-v3.h , copy the one GITS_TRANSLATER register offset macro directly into the driver. This repairs the ability to build the driver on non-ARM non-GIC targets the way it was possible until now, which retains good build test coverage. Reported-by: kernel test robot <[email protected]> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ Signed-off-by: Marek Vasut <[email protected]> --- Cc: "Krzysztof Wilczyński" <[email protected]> Cc: Bjorn Helgaas <[email protected]> Cc: Catalin Marinas <[email protected]> Cc: Conor Dooley <[email protected]> Cc: Geert Uytterhoeven <[email protected]> Cc: Krzysztof Kozlowski <[email protected]> Cc: Lorenzo Pieralisi <[email protected]> Cc: Manivannan Sadhasivam <[email protected]> Cc: Marc Zyngier <[email protected]> Cc: Rob Herring <[email protected]> Cc: Yoshihiro Shimoda <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] --- Note: The alternative I could think of would be ifdeffery which is not nice and thwarts the build coverage, or limit the driver to ARM/ARM64 in Kconfig which also thwarts the build coverage. I could also split off the register macros in linux/irqchip/arm-gic-v3.h into some separate header linux/irqchip/arm-gic-v3-regs.h and include that which might be OKish and avoids duplication. Thoughts ? --- drivers/pci/controller/dwc/pcie-rcar-gen4.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-rcar-gen4.c b/drivers/pci/controller/dwc/pcie-rcar-gen4.c index 5f7211b91ee5b..4b75615c516f0 100644 --- a/drivers/pci/controller/dwc/pcie-rcar-gen4.c +++ b/drivers/pci/controller/dwc/pcie-rcar-gen4.c @@ -13,7 +13,6 @@ #include <linux/interrupt.h> #include <linux/io.h> #include <linux/iopoll.h> -#include <linux/irqchip/arm-gic-v3.h> #include <linux/module.h> #include <linux/of.h> #include <linux/of_address.h> @@ -26,6 +25,9 @@ #include "../../pci.h" #include "pcie-designware.h" +/* GIC ITS TRANSLATER register offset in GIC ITS space */ +#define GITS_TRANSLATER 0x10040 + /* Renesas-specific */ /* PCIe Mode Setting Register 0 */ #define PCIEMSR0 0x0000 -- 2.53.0