Re: [PATCH] PCI: rcar-gen4: Inline GIC_TRANSLATER offset macro
Marc Zyngier <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 09 Jul 2026 21:10:03 +0100, Marek Vasut <[email protected]> wrote: > > Instead of pulling in the whole linux/irqchip/arm-gic-v3.h , copy the > one GITS_TRANSLATER register offset macro directly into the driver. > This repairs the ability to build the driver on non-ARM non-GIC targets > the way it was possible until now, which retains good build test coverage. > > Reported-by: kernel test robot <[email protected]> > Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ > Signed-off-by: Marek Vasut <[email protected]> > --- > Cc: "Krzysztof Wilczyński" <[email protected]> > Cc: Bjorn Helgaas <[email protected]> > Cc: Catalin Marinas <[email protected]> > Cc: Conor Dooley <[email protected]> > Cc: Geert Uytterhoeven <[email protected]> > Cc: Krzysztof Kozlowski <[email protected]> > Cc: Lorenzo Pieralisi <[email protected]> > Cc: Manivannan Sadhasivam <[email protected]> > Cc: Marc Zyngier <[email protected]> > Cc: Rob Herring <[email protected]> > Cc: Yoshihiro Shimoda <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > --- > Note: The alternative I could think of would be ifdeffery which > is not nice and thwarts the build coverage, or limit the > driver to ARM/ARM64 in Kconfig which also thwarts the build > coverage. I could also split off the register macros in > linux/irqchip/arm-gic-v3.h into some separate header > linux/irqchip/arm-gic-v3-regs.h and include that which > might be OKish and avoids duplication. Thoughts ? No, I'm not hacking something that is purely architecture specific for the purpose of a bizarre integration quirk that should be handled by the boot firmware, and not Linux. Add whatever you want to the PCI glue code, limit this to arm64 (which is the only architecture this can ever be used on, and the build coverage argument really doesn't hold), but please leave the GIC code alone. M. -- Jazz isn't dead. It just smells funny.