Re: [PATCH 01/16] dt-bindings: clock: Introduce nexus nodes
Miquel Raynal <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-clk,org.kernel.vger.linux-crypto,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hello Rob, >> +title: Clock Nexus >> + >> +description: > >> + A nexus node allows to remap a phandle list in a consumer node through a >> + container or a connector node in a generic way. With this remapping, >> + the consumer node needs to know only about the nexus node. Resources >> + behind the nexus node are decoupled by the nexus node itself. >> + >> +maintainers: >> + - Miquel Raynal <[email protected]> >> + >> +select: true >> + >> +properties: >> + '#clock-cells': true > > No need for this. I wasn't sure, I'll drop it. >> + clock-map: >> + $ref: /schemas/types.yaml#/definitions/uint32-matrix >> + >> + clock-map-mask: >> + $ref: /schemas/types.yaml#/definitions/uint32-array >> + >> + clock-map-pass-thru: >> + $ref: /schemas/types.yaml#/definitions/uint32-array > > I think this can be omitted because there aren't common cell definitions > for clocks like there are for GPIO and PWM. I agree, same here I wanted to mimic the existing nexus, but I agree it is not super useful for clocks. It can be added later anyway, if ever needed. I assume you mean here that we must drop both clock-map-mask and clock-map-pass-thru, but obviously not clock-map. Thanks, Miquèl