Re: [PATCH v2 05/10] dt-bindings: clock: renesas,r8a78000-cpg: Add firmware property
Geert Uytterhoeven <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,org.infradead.lists.linux-arm-kernel,org.kernel.vger.arm-scmi,org.kernel.vger.linux-clk,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm |
|---|---|
| Message-ID | <CAMuHMdV=ckONBbTYELPJU8YWoNzdu3PJ95VR8cz+f_7dUeiPUw@mail.gmail.com> |
Hi Krzysztof, On Fri, 10 Jul 2026 at 12:21, Krzysztof Kozlowski <[email protected]> wrote: > On Wed, Jul 08, 2026 at 12:16:23PM +0200, Geert Uytterhoeven wrote: > > Add a firmware property, for systems where SCMI must be used instead of > > direct hardware access. > > > > Signed-off-by: Geert Uytterhoeven <[email protected]> > > --- > > v2: > > - Spin off from "dt-bindings: clock: Document Renesas R-Car X5H Clock > > Pulse Generator". > > --- > > .../devicetree/bindings/clock/renesas,r8a78000-cpg.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/clock/renesas,r8a78000-cpg.yaml b/Documentation/devicetree/bindings/clock/renesas,r8a78000-cpg.yaml > > index 4e23bba334382346..fc499e7cf52e4f0c 100644 > > --- a/Documentation/devicetree/bindings/clock/renesas,r8a78000-cpg.yaml > > +++ b/Documentation/devicetree/bindings/clock/renesas,r8a78000-cpg.yaml > > @@ -35,6 +35,12 @@ properties: > > <dt-bindings/clock/renesas,r8a78000-cpg.h>. > > const: 1 > > > > + firmware: > > RPi is doing similar, but I have doubts. It looks way too close to > generic "syscon" which is disallowed. > > I think this should be vendor+purpose specific, e.g.: > "renesas,scmi-transport" or "renesas,scmi-firmware" The disadvantage of a vendor-specific property is that there are more cases to handle for fw_devlink, cfr. "[PATCH v2 02/10] of: property: fw_devlink: Add support for firmware"[1]. > Also we have "firmware" nodes, so this might cause conflicts in dtschema > validation. Anyway, the phandle itself is fine for me, just the naming. > > I'll ping also Rob to chime in. Thanks! [1] https://lore.kernel.org/de34ac0c52695d92c67cf950b3d8e9b30095d305.1783505329.git.geert+renesas@glider.be Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds