Re: [PATCH 10/16] clk: Add support for clock nexus dt bindings
Miquel Raynal <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-clk,org.kernel.vger.linux-crypto,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hello, >> > Before I left my Reviewed-by, I should have double checked Sashiko. It >> > has several questions about this patch. The first is: >> > >> > Are there other places in the clock framework that need to transition to the >> > new map API to ensure assigned clocks work? >> > >> > For instance, assigned-clocks and assigned-clock-parents are parsed in >> > drivers/clk/clk-conf.c using of_parse_phandle_with_args(). If a device >> > specifies an assigned clock that routes through a nexus node, will it fail >> > to configure because the map is not traversed? >> >> The goal of the nexus node is to isolate what is behind. Are >> assigned-clocks et al. supposed to traverse a nexus node? I am tempted >> to say "no", but I'm open to discussing this ofc. > > Why would assigned-clocks not traverse the nexus node? If I'm a DT > author I would think any clock specifier should be routed properly > through the nexus node. Ok, giving this another thought, it may indeed be relevant to apply a default frequency which needs to traverse the nexus to be active. I've done the same change in the clk-conf.c file and tested with a dummy example, it just works. Thanks, Miquèl