Re: [PATCH 00/26] dmaengine: Remove redundant error messages on IRQ request failure
Vinod Koul <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,dev.linux.lists.imx,dev.linux.lists.linux-sunxi,org.infradead.lists.linux-mediatek,org.infradead.lists.linux-riscv,org.kernel.vger.dmaengine,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mips,org.kernel.vger.linux-tegra |
|---|---|
| Message-ID | <alYmNl--mxMK1-86@vaman> |
On 09-07-26, 16:26, Wolfram Sang wrote:
> On Thu, Jul 09, 2026 at 09:58:04PM +0800, Pan Chuang wrote:
> > Commit 55b48e23f5c4b6f5ca9b7ab09599b17dcf501c10 ("genirq/devres: Add
> > error handling in devm_request_*_irq()") added automatic error logging
> > to devm_request_threaded_irq() and devm_request_any_context_irq() via
> > the new devm_request_result() helper. The helper prints device name,
> > IRQ number, handler functions, and error code on failure.
> >
> > Since devm_request_irq() is a static inline wrapper around
> > devm_request_threaded_irq(), it also benefits from this automatic
> > logging.
> >
> > This series removes the now-redundant dev_err() and dev_err_probe() calls
> > in dmaengine drivers that follow these devm_request_*_irq() functions,
> > as the core now provides more detailed diagnostic information on failure.
> >
> > Pan Chuang (26):
> > dmaengine: fsl-edma-main: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: fsl-qdma: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: loongson-loongson1-apb-dma: Remove redundant
> > dev_err()/dev_err_probe()
> > dmaengine: mediatek-mtk-cqdma: Remove redundant
> > dev_err()/dev_err_probe()
> > dmaengine: mediatek-mtk-hsdma: Remove redundant
> > dev_err()/dev_err_probe()
> > dmaengine: mmp_pdma: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: moxart-dma: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: owl-dma: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: pxa_dma: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: qcom-gpi: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: sf-pdma-sf-pdma: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: sh-rcar-dmac: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: sh-rz-dmac: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: sh-shdmac: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: sh-usb-dmac: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: sprd-dma: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: st_fdma: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: stm32-stm32-dma: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: stm32-stm32-dma3: Remove redundant
> > dev_err()/dev_err_probe()
> > dmaengine: stm32-stm32-mdma: Remove redundant
> > dev_err()/dev_err_probe()
> > dmaengine: sun4i-dma: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: sun6i-dma: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: tegra20-apb-dma: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: ti-edma: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: uniphier-xdmac: Remove redundant dev_err()/dev_err_probe()
> > dmaengine: xgene-dma: Remove redundant dev_err()/dev_err_probe()
>
> One patch per subsystem for such trivial changes, please.
Yes pretty please
--
~Vinod