Re: [PATCH v2 08/12] ASoC: simple-card: tidyup simple_util_parse_xxx() in simple_parse_of()

Hi Geert, Mark

Thank you for your report

> This breaks sound on Koelsch and RZ/Five:
> 
>     asoc-simple-card sound: error -EINVAL: parse error
>     asoc-simple-card sound: probe with driver asoc-simple-card failed with error -22
>     ...
>     ALSA device list:
>      No soundcards found.
(snip)
> All changed functions return zero, but the call to
> devm_snd_soc_register_card() below returns -EINVAL:

Grr, it was a pattern that fell outside my test cases.
... and Mark had pointed out it.

Please let me explain myself.

The reason was it didn't have card->name.
Card name setting function will try to set name by

	1. from "label" property
	2. from "name"  property
	3. from dai_link->name

My all test case have label (= 1), So my test didn't get damage :(
And, in case of Simple-Card, it call the function with PREFIX,
all 1/2/3 will fail.
In case of Audio-Graph-Card/Card2, it call the function without PREFIX,
it will get DT node name (= 2).

Anyway, I will send the fixup patch.


Thank you for your help !!

Best regards
---
Kuninori Morimoto