Re: [PATCH v2] PCI: rcar-gen4: Isolate driver to ARM64
Manivannan Sadhasivam <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <jipy4hvsmksv6fy352y23sjdnutpkqoi2577qp5vymqqggiscz@cnx2vijnhvh4> |
On Tue, Jul 14, 2026 at 04:10:30PM -0500, Bjorn Helgaas wrote: > On Tue, Jul 14, 2026 at 03:19:27PM +0200, Marek Vasut wrote: > > The driver includes linux/irqchip/arm-gic-v3.h which pulls in headers > > which are available only on ARM and ARM64, on other architectures the > > headers are not present and the driver fails to build. This driver is > > used only on ARM64 hardware, isolate its build only to ARM64 to avoid > > build failures on other architectures. > > > > Reported-by: kernel test robot <[email protected]> > > Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ > > Signed-off-by: Marek Vasut <[email protected]> > > Mani, I assume you'll squash this into 89bded511a66 ("PCI: rcar-gen4: > Configure AXIINTC if iMSI-RX is not used") so it's connected to the > addition of the linux/irqchip/arm-gic-v3.h include and there's no > bisection hole? > Yes, squashed now! - Mani > > --- > > Cc: "Krzysztof Wilczyński" <[email protected]> > > Cc: Bjorn Helgaas <[email protected]> > > Cc: Catalin Marinas <[email protected]> > > Cc: Conor Dooley <[email protected]> > > Cc: Geert Uytterhoeven <[email protected]> > > Cc: Krzysztof Kozlowski <[email protected]> > > Cc: Lorenzo Pieralisi <[email protected]> > > Cc: Manivannan Sadhasivam <[email protected]> > > Cc: Marc Zyngier <[email protected]> > > Cc: Rob Herring <[email protected]> > > Cc: Yoshihiro Shimoda <[email protected]> > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > --- > > V2: This is a rework of PCI: rcar-gen4: Inline GIC_TRANSLATER offset macro > > which isolates the driver build to ARM64 via Kconfig instead: > > https://lore.kernel.org/linux-pci/CAMuHMdVvWE7YZgKvreSn_vJLOVD4eMmn3TCGOyqSXksqjBCwvg@mail.gmail.com/ > > https://lore.kernel.org/linux-pci/20260714110041.GA1349622@bhelgaas/ > > --- > > drivers/pci/controller/dwc/Kconfig | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > > index 49a7a2c50ca15..3260d916110b2 100644 > > --- a/drivers/pci/controller/dwc/Kconfig > > +++ b/drivers/pci/controller/dwc/Kconfig > > @@ -346,7 +346,7 @@ config PCIE_RCAR_GEN4 > > > > config PCIE_RCAR_GEN4_HOST > > tristate "Renesas R-Car Gen4 PCIe controller (host mode)" > > - depends on ARCH_RENESAS || COMPILE_TEST > > + depends on ARM64 && (ARCH_RENESAS || COMPILE_TEST) > > depends on PCI_MSI > > select PCIE_DW_HOST > > select PCIE_RCAR_GEN4 > > @@ -357,7 +357,7 @@ config PCIE_RCAR_GEN4_HOST > > > > config PCIE_RCAR_GEN4_EP > > tristate "Renesas R-Car Gen4 PCIe controller (endpoint mode)" > > - depends on ARCH_RENESAS || COMPILE_TEST > > + depends on ARM64 && (ARCH_RENESAS || COMPILE_TEST) > > depends on PCI_ENDPOINT > > select PCIE_DW_EP > > select PCIE_RCAR_GEN4 > > -- > > 2.53.0 > > -- மணிவண்ணன் சதாசிவம்