Re: [PATCH] ARM: dts: renesas: r9a06g032-rzn1d400-eb: enable GPIOs on CN12

Wolfram Sang <[email protected]>
Newsgroups org.kernel.vger.linux-renesas-soc,dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-devicetree
Message-ID <aliVVqnokN4s856T@ninjato>
> > The snps,dw-apb-gpio driver iterates over its port subnodes (like gpio2b)
> > to register gpio_chip interfaces, but it doesn't appear to register these
> > subnodes as independent platform devices.
> >
> > Because the driver core only applies pinctrl-0 properties automatically
> > during probe for fully initialized device instances, this configuration
> > might be silently ignored by the kernel.
>
> True. Will rework.

After some more research: not true

gpiolib handles this, check this comment:

5351 /*
5352  * The DT node of some GPIO chips have a "compatible" property, but
5353  * never have a struct device added and probed by a driver to register
5354  * the GPIO chip with gpiolib. In such cases, fw_devlink=on will cause
5355  * the consumers of the GPIO chip to get probe deferred forever because
5356  * they will be waiting for a device associated with the GPIO chip
5357  * firmware node to get added and bound to a driver.
5358  *
5359  * To allow these consumers to probe, we associate the struct
5360  * gpio_device of the GPIO chip with the firmware node and then simply
5361  * bind it to this stub driver.
5362  */

Further proof, 'pinmux-pins' in debugfs shows that these pins are tied
to the gpiochip with this patch. It doesn't without this patch.

I think it is okay as-is. But I need to make another update anyhow, so I
will send a v2 nonetheless.
signature.asc (application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmpYlVIACgkQFA3kzBSg
KbbkPhAAi0TEZA7foWQWPRdzjz6wKn+SqHwPsiScZj/fmC0C9yBo2rmXnFo+4EC6
YiofFpn0y1oDjR5Y6zpxaJ7xkYTFryIyQSg74raot/OOL2LwRpPNXesjFz85fnNz
IuoLTeO+JAUjVfZLxDmqCUKnvxvVgqgd62102hhIxWRFT0k9Bprr53LlnhRyia6+
9OVIrKULthTzSNqIW5x0HkEd3BszjUJf/ZaziZMYAp58QNIMp5vR6qRUf9wSxEaa
yINgQUMVq0h2gtxl5JYweAEzaHvD9ik8vQTUVj+zj+/pK6Zd01GQxmb/TrXJL2dr
eYltyipNs6JJZLGY+BSdnKid/Qte0dORdhtEho5SkTrVuCddYZSnmJyLX68hJsh2
SUGSO45V2SCgyiKtStjHL/0Fm+OaV+5Ots38kKpL/oPG1F6y0hzGLRRNWTc+bfng
UoFJU1ggCjHkFTzU9gLcbbAKb8isYyOd83XAmLgciMPWOkYge3CSOmtMLfWNlL2q
ZaFLF7SQDLUYYhI4+jpbavpq8rbjnRk92cdSLQXcAwkuFFldnJYjNBUt4hfEYBGW
S6BJKLpgjhjZ8Tty2z5HZQE6ynOtlT0Z+qzDI10U56kcGZkIRF3IAIicSBemzdDQ
Z2tqW1UyBUZwWqi90nJ0MshKfCKw148by/sWK+xprObdIc67YKo=
=6KMV
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.