Re: [PATCH v3 1/4] drm/panel: have drm_panel_add/remove manage a list reference
Luca Ceresoli <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,dev.linux.lists.imx,dev.linux.lists.linux-sunxi,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-rockchip,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mips,org.kernel.vger.linux-samsung-soc,org.kernel.vger.linux-tegra |
|---|---|
| Message-ID | <178455311420.13699.8663194161484275449.b4-review@b4> |
On Fri, 17 Jul 2026 16:02:04 +0200, Albert Esteve <[email protected]> wrote: > The global panel_list holds raw pointers to drm_panel objects. > Nothing prevents a panel from being freed while it is still linked > in the list: if a driver's probe calls drm_panel_add() and then > fails at a later step, panel->list remains in panel_list. Any > subsequent call to of_drm_find_panel() that iterates the list will > dereference freed memory. > > [...] Reviewed-by: Luca Ceresoli <[email protected]> -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com