Re: [PATCH 01/15] drm/exynos: remove dependency on DRM simple helpers
Thomas Zimmermann <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,dev.linux.lists.imx,dev.linux.lists.virtualization,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-amlogic,org.infradead.lists.linux-mediatek,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-samsung-soc,org.kernel.vger.linux-tegra |
|---|---|
| Message-ID | <[email protected]> |
Hi Am 20.07.26 um 17:15 schrieb Diogo Silva: > Hey, > >> Again, you rather want drm_err() with drm_dev here. >> >> I've briefly looked over the series and many patches seem affected. >> Please prefer drm_ logging functions and DRM devices over the plain >> device equivalents. > Thanks. I will submit a v2 with consistent usage of drm_err(). Thanks > > Also, is there any ongoing task or would it be useful to submit patches > changing the usage of DRM_DEV_* functions with drm_* equivalents? > Or from dev_* to drm_* when possible ? Possibly. DRM_DEV_ logging is supposed to be replaced with drm_ logging helpers. That would be a simple follow-up series. Whether to prefer drm_ over dev_ logging depends on the context and the driver maintainer. Best regards Thomas > > BR, > Diogo -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)