Re: [PATCH v2 2/6] ASoC: renesas: fsi: Drop platform probing metadata

Kuninori Morimoto <[email protected]> Mon, 20 Jul 2026 23:12:39 +0000
Newsgroups org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound
Message-ID <[email protected]>
Hi Uwe

Thank you for the patch

> Since commit 38d3273075d6 ("ASoC: renesas: fsi: remove platform data
> style support") probing using the traditional platform bus matching
> isn't supported any more.
> 
> Drop the platform_device_id entries that should have been removed in the
> above commit. Note that keeping the empty array results in the driver
> not matching on "fsi-pcm-audio" (i.e. the driver name).
> 
> While touching that array, use a single space and no trailing comma for
> the list terminator, which is the most used style for this.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <[email protected]>

Yes, indeed. id_table is no longer needed

> I was unsure about keeping the array. Also dropping
> MODULE_DEVICE_TABLE() if keeping it might be worth a thought.

Yeah.
Because it doesn't support platform data style, id_table itself
is no longer needed. Our other driver which support DT style only
doesn't have id_table.


Thank you for your help !!

Best regards
---
Kuninori Morimoto