Re: [PATCH 1/3] PCI: rzg3s: Disable refclk on probe failure

claudiu beznea <[email protected]> Thu, 23 Jul 2026 20:16:50 +0300

Newsgroups	org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci,org.kernel.vger.stable
Message-ID	<[email protected]>


On 7/16/26 01:30, Prabhakar wrote:
> From: Lad Prabhakar<[email protected]>
> 
> rzg3s_pcie_host_init_port() enables the PCIe reference clock using
> clk_prepare_enable(), but if rzg3s_pcie_probe() subsequently fails, for
> example because pci_host_probe() returns an error, the probe error path
> only releases the clock handle with clk_put().
> 
> Balance clk_prepare_enable() by calling clk_disable_unprepare() in the
> probe cleanup path before releasing the clock, ensuring the reference
> clock is properly disabled on probe failure.
> 
> Fixes: 7ef502fb35b28 ("PCI: Add Renesas RZ/G3S host controller driver")
> Cc:[email protected]
> Signed-off-by: Lad Prabhakar<[email protected]>

Reviewed-by: Claudiu Beznea <[email protected]>