Re: [PATCH 4/9] media: rzg2l-cru: Drop stop streaming function

Hi Tommaso

On Tue, Jun 16, 2026 at 07:05:34PM +0200, Tommaso Merciai wrote:
> Drop rzg2l_cru_stop_streaming() function and replace that with the
> direct call to rzg2l_cru_set_stream(cru, 0).
>
> This is a refactoring with no functional changes.
>
> Signed-off-by: Tommaso Merciai <[email protected]>

Reviewed-by: Jacopo Mondi <[email protected]>

Thanks
  j

> ---
>  drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> index bf61a74f8f74..e283d9b69342 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> @@ -583,11 +583,6 @@ static int rzg2l_cru_set_stream(struct rzg2l_cru_dev *cru, int on)
>  	return ret;
>  }
>
> -static void rzg2l_cru_stop_streaming(struct rzg2l_cru_dev *cru)
> -{
> -	rzg2l_cru_set_stream(cru, 0);
> -}
> -
>  irqreturn_t rzg2l_cru_irq(int irq, void *data)
>  {
>  	struct rzg2l_cru_dev *cru = data;
> @@ -736,7 +731,7 @@ static void rzg2l_cru_stop_streaming_vq(struct vb2_queue *vq)
>  {
>  	struct rzg2l_cru_dev *cru = vb2_get_drv_priv(vq);
>
> -	rzg2l_cru_stop_streaming(cru);
> +	rzg2l_cru_set_stream(cru, 0);
>
>  	/* Free scratch buffer */
>  	dma_free_coherent(cru->dev, cru->format.sizeimage,
> --
> 2.54.0
>