[PATCH 0/9] iio: fix write_raw() return values and remove pm helpers
Sang-Heon Jeon <[email protected]> Tue, 28 Jul 2026 03:47:37 +0900
| Newsgroups | org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hello, This series fixes write_raw() return values and removes pm runtime helpers in iio drivers, as Jonathan suggested when reviewing the original iio patch [1]. Patches 1-2 fix write_raw() in isl29028 and tsl2583 to always return zero on success. write_raw() returns the value of pm_runtime_put_autosuspend(), which is 1 if the device is already runtime suspended. In that case write() on the sysfs attribute returns 1 instead of the number of bytes written. Patches 3-7 remove the pm runtime helpers in isl29028, tsl2583, vcnl4035, vcnl4000 and rcar-gyroadc. Each helper just calls pm_runtime_resume_and_get() or pm_runtime_put_autosuspend() depending on its bool argument and adds no value. Patches 8-9 are the remaining conditional return cleanups from the original patch, generated by the Coccinelle script. [1] https://lore.kernel.org/all/[email protected]/ --- Sang-Heon Jeon (9): iio: light: isl29028: return zero in write_raw() on success iio: light: tsl2583: return zero in write_raw() on success iio: light: isl29028: remove isl29028_set_pm_runtime_busy() helper iio: light: tsl2583: remove tsl2583_set_pm_runtime_busy() helper iio: light: vcnl4035: remove vcnl4035_set_pm_runtime_state() helper iio: light: vcnl4000: remove vcnl4000_set_pm_runtime_state() helper iio: adc: rcar-gyroadc: remove rcar_gyroadc_set_power() helper iio: light: tsl2583: remove conditional return with no effect iio: magnetometer: ak8974: remove conditional return with no effect drivers/iio/adc/rcar-gyroadc.c | 14 ++------------ drivers/iio/light/isl29028.c | 22 ++++++--------------- drivers/iio/light/tsl2583.c | 32 ++++++++++--------------------- drivers/iio/light/vcnl4000.c | 14 ++------------ drivers/iio/light/vcnl4035.c | 18 ++++------------- drivers/iio/magnetometer/ak8974.c | 6 +----- 6 files changed, 25 insertions(+), 81 deletions(-) -- 2.43.0