Re: [PATCH 3/9] media: rzg2l-cru: Use bulk reset API in rzg2l_cru_start_streaming_vq()

Hi Philipp,
Thanks for your review.

On Tue, Jul 28, 2026 at 08:59:07AM +0200, Philipp Zabel wrote:
> On Di, 2026-06-16 at 19:05 +0200, Tommaso Merciai wrote:
> > Replace individual reset_control_deassert() calls for aresetn and presetn
> > with reset_control_bulk_deassert(), and consolidate the error path labels
> > into a single err_assert_resets using reset_control_bulk_assert().
> > 
> > No functional changes intended.
> > 
> > Signed-off-by: Tommaso Merciai <[email protected]>
> > ---
> >  .../platform/renesas/rzg2l-cru/rzg2l-video.c  | 23 ++++++++-----------
> >  1 file changed, 9 insertions(+), 14 deletions(-)
> > 
> > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> > index 5185a547461d..bf61a74f8f74 100644
> > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> > @@ -672,6 +672,10 @@ irqreturn_t rzg3e_cru_irq(int irq, void *data)
> >  static int rzg2l_cru_start_streaming_vq(struct vb2_queue *vq, unsigned int count)
> >  {
> >  	struct rzg2l_cru_dev *cru = vb2_get_drv_priv(vq);
> > +	struct reset_control_bulk_data resets[] = {
> > +		{ .rstc = cru->aresetn },
> > +		{ .rstc = cru->presetn },
> > +	};
> 
> Why doesn't this also request the resets in bulk?

presetn -> is shared with csi2 ip
aresetn -> is exclusive

This is why IMHO we can't request the resets in bulk.

Kind Regards,
Tommaso


> 
> regards
> Philipp