Re: [PATCH 2/3] power: sequencing: Add Renesas RZ/G3L Power Ready driver
Bartosz Golaszewski <[email protected]> Tue, 28 Jul 2026 04:34:43 -0700
| Newsgroups | org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm |
|---|---|
| Message-ID | <CAMRc=MdU12B-+vQxCuFVuoJLLza_51-bv1o1T9VYEHbkiZF1EA@mail.gmail.com> |
On Tue, 28 Jul 2026 11:17:58 +0200, Biju Das <[email protected]> said: > Hi Bartosz Golaszewski, > > Thanks for the feedback. > ... >> > + >> > +static int pwrseq_rzg3l_pwrrdy_match(struct pwrseq_device *pwrseq, >> > + struct device *dev) >> > +{ >> > + return PWRSEQ_MATCH_OK; >> >> When I see an always-tru match() callback, it always raises an alarm bell. >> Typically, I'd expect there to be some validation of the consumer happening. >> >> Please at least provide an explanation of why it's ok. > > Without the match function the driver is not probing. > Yes, that's expected. > sysc(driver) ->powerseq(driver) ->{DSI,CSI,USB}(driver) > there is no property that I can match here as the resource is a register on > the SYSC IP and powerseq driver is instantiated by the SYSC driver. > > Maybe I can provide a comment here saying that?? > "No DT property to match here, so it is OK always" > So the sysc is the parent of the pwrseq provider and the CSI, DSI and USB drivers are the consumers of the pwrseq descriptor? The latter are children of the platform bus, am I getting this right? Can you point me to the device tree that describes it? Bart