Re: [PATCH v2 06/10] net: pcs: xpcs: add ANRESTART support for SGMII link recovery

On Sun, Aug 02, 2026 at 11:11:40AM +0800, Coia Prant wrote:
> Hi Andrew,
> 
> Thanks for the careful review.
> 
> > This probably needs more wide spread testing. I would be afraid that
> > if you kick off an AN cycle, you loose the link until it completes?
> > You would of noticed that on your hardware, but other hardware
> > obviously behaves differently...
> 
> The trigger condition is: link is down AND an_complete is set.

Ah, i missed the "link is down" check. That makes it safer.

I still find it interesting that this devices is different. Has the
silicon vendor done the integration of the licensed IP wrong?

> Regarding testing:
> - Jiawen Wu has tested this on Wangxun NICs and reported no regression
>   (Tested-by tag included in the patch).

Probably Maxime will test on the platform he has, but i don't know if
any use the XPCS.

	Andrew