Re: [PATCH] phy: renesas: rcar-gen2: Fix double of_node_put on phy creation failure
Krzysztof Kozlowski <[email protected]> Mon, 3 Aug 2026 15:09:05 +0200
| Newsgroups | org.kernel.vger.linux-renesas-soc,org.infradead.lists.linux-phy,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 03/08/2026 14:43, Felix Gu wrote:
> for_each_child_of_node_scoped() releases the node reference on scope
> exit, so the explicit of_node_put(np) in the devm_phy_create() error
> path drops it twice.
>
> Drop the redundant of_node_put() and let the scoped cleanup handle it.
>
> Fixes: b64b32791fb5 ("phy: renesas: rcar-gen2: Simplify with scoped for each OF child loop")
> Signed-off-by: Felix Gu <[email protected]>
> ---
> drivers/phy/renesas/phy-rcar-gen2.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof