Re: [PATCH v1 2/2] usb: dwc3: Add Renesas R-Car Gen5 DWC3 xHCI USB controller glue

Marek Vasut <[email protected]> Thu, 6 Aug 2026 05:28:26 +0200

Newsgroups	org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-usb
Message-ID	<[email protected]>

On 8/5/26 9:53 AM, Geert Uytterhoeven wrote:

Hello Geert,

> On Wed, 5 Aug 2026 at 02:48, Thinh Nguyen <[email protected]> wrote:
>> On Tue, Jul 28, 2026, Marek Vasut wrote:
>>> --- /dev/null
>>> +++ b/drivers/usb/dwc3/dwc3-rcar-gen5.c
> 
>>> +static int __maybe_unused dwc3_rcar_gen5_suspend(struct device *dev)
>>
>> Avoid using __maybe_unused. If it's not used, remove it.
> 
> Whether the function is used or not depends on CONFIG_PM_SLEEP ;-)
> 
>>> +static DEFINE_RUNTIME_DEV_PM_OPS(dwc3_rcar_gen5_pm_ops,
>>> +                              dwc3_rcar_gen5_suspend,
>>> +                              dwc3_rcar_gen5_resume, NULL);
> 
> As DEFINE_RUNTIME_DEV_PM_OPS() uses pm_sleep_ptr()
> internally, the __maybe_unused annotations above can be removed.
The __maybe_unused is dropped and pm_ptr() added in V2, thanks !