Re: [PATCH v2 2/2] ARM: dts: renesas: r9a06g032-rzn1d400-eb: enable GPIOs on CN12
Wolfram Sang <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <anqAKtaFCxADeLqM@shikoro> |
> > + pins_gpio2b: pins-gpio2b {
>
> pins-cn12?
Okay.
> > + pinmux = <RZN1_PINMUX(164, RZN1_FUNC_GPIO)>,
> > + <RZN1_PINMUX(165, RZN1_FUNC_GPIO)>,
> > + <RZN1_PINMUX(166, RZN1_FUNC_GPIO)>,
> > + <RZN1_PINMUX(167, RZN1_FUNC_GPIO)>,
> > + <RZN1_PINMUX(168, RZN1_FUNC_GPIO)>,
> > + <RZN1_PINMUX(169, RZN1_FUNC_GPIO)>;
> > + drive-strength = <6>;
> > + bias-disable;
>
> These pins don't have any external pull-ups, so disabling bias will
> make them pick-up random EM noise when left unconnected.
Can fix, but is this bad? I'd assume the connected pins will handle it.
And if not, the DT needs to be adapted to that use case. Otherwise, a
default pull-up needs to be disabled for another use case.
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmp6gCYACgkQFA3kzBSg KbYxFQ//aoMqyCZjSWPRU9o+uBsWOglUgPZRJ2OnvQbePBuQ9pt5Pafa8XEUaRw9 MkvdMiv0IfKzrEj1+v+oNjvGFU+LHSn5sR5i+CDLD8+bPy31F6XNA3nyldwfXbBA yRsbl/BPgA2hZG1GCLPGzZxil+sqMdfjYAuuk6qxLbGIXE9jX1FYWb+GC0mK0h+t ggJQoP7X2VIFbw/nFAYuECnSnwkadM+TDItgr3X0PE1VGc4q2YHNQSYrAymqGEPy PvRtSFhsS+wxF3+MF5CwxZ6MrJMaUZheJPzEAKRvTLwIpuXZEyJx5aHjlcl3v/Wy tnL8ubEBSOR+aNRn8wvaS0dP87tPwpZtX+24TPG9+sAo5qKbaIHKiBTj/bFWdmg0 HwyQbJRy8/Y4/vBZKTVTTIoU67TYnBk5dJx9VzM8nbiJl/VAY1H7Bewc4RK86Yqq Vh66GcQ8R8FzkHgSjgXVd6sIrdr1ODNHrQBq/WEVHnCvGfoigkG6BwHT5FIv/eML YB3rgJm+ORLX/yTgBXzNo+0nYnJBAxOThKziaZ5ztc++9hPJNl63aM+oeL5oBA+5 HL+HJy2NtIXqeRPHMZOOuWzQKhzIrIWuWiNoIYi2j9oLPudsYEruBdvAmurLTqbI PBcn+1USAbDSsBjL/z1WQfNOVDy5uut5v9swVlcNJUaiN+NaSG8= =0yYX -----END PGP SIGNATURE-----