Re: [PATCH v3 1/2] dt-bindings: usb: dwc3: Document Renesas R-Car Gen5 DWC3 xHCI USB controller
Geert Uytterhoeven <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-usb |
|---|---|
| Message-ID | <CAMuHMdXU0Z_VP7H3=KX1g7wowG1ZDi__nDgWRmquYxhLHKvd7A@mail.gmail.com> |
On Mon, 17 Aug 2026 at 09:01, Krzysztof Kozlowski <[email protected]> wrote: > On Tue, Aug 11, 2026 at 07:09:33AM +0200, Marek Vasut wrote: > > The Renesas R-Car Gen5 SoC contains multiple instances of DWC3 USB > > controller with glue logic wrapper around them. Document the glue > > logic and DWC3 controller. > > > > Signed-off-by: Marek Vasut <[email protected]> > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/renesas,rcar-gen5-dwc3.yaml > > + dr_mode: > > We don't accept properties with underscores, unless this is coming from > existing schema but I do not see snps,dwc referenced in the binding. > > > + enum: [ host, otg, peripheral ] Probably this should just reference usb/usb-drd.yaml instead of defining it itselves. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds